Skip to content

[ZEPPELIN-951] Update cron expression link and fix broken cron container style#959

Closed
minahlee wants to merge 1 commit into
apache:masterfrom
minahlee:ZEPPELIN-951
Closed

[ZEPPELIN-951] Update cron expression link and fix broken cron container style#959
minahlee wants to merge 1 commit into
apache:masterfrom
minahlee:ZEPPELIN-951

Conversation

@minahlee
Copy link
Copy Markdown
Member

@minahlee minahlee commented Jun 4, 2016

What is this PR for?

Update cron expression link and fix broken cron container style

What type of PR is it?

Bug Fix

What is the Jira issue?

ZEPPELIN-951

Screenshots (if appropriate)

Before
screen shot 2016-06-03 at 7 01 00 pm

After
screen shot 2016-06-03 at 7 00 39 pm

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Leemoonsoo
Copy link
Copy Markdown
Member

LGTM

1 similar comment
@cloverhearts
Copy link
Copy Markdown
Member

LGTM

@minahlee
Copy link
Copy Markdown
Member Author

minahlee commented Jun 4, 2016

Same test failure is already reported by @bzz in https://issues.apache.org/jira/browse/ZEPPELIN-942

@astroshim
Copy link
Copy Markdown
Contributor

LGTM

@prabhjyotsingh
Copy link
Copy Markdown
Contributor

Hi @minahlee,
This CI failure is fixed with #958. Can you rebase with master and re-trigger ?

@minahlee
Copy link
Copy Markdown
Member Author

minahlee commented Jun 4, 2016

@prabhjyotsingh Test is passing now! Thanks for taking care of it

@prabhjyotsingh
Copy link
Copy Markdown
Contributor

LGTM. Will Merge this if no more discussion.

@asfgit asfgit closed this in 0ee329f Jun 5, 2016
@minahlee minahlee deleted the ZEPPELIN-951 branch June 23, 2016 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants